Second try at fixing issue #9 after rebasing.

callumrollo / erddaplogs

Quick utilities for parsing nginx and apache logs for ERDDAP requests

MIT License

0 stars 4 forks source link

Second try at fixing issue #9 after rebasing. #38

Closed aalloilla closed 1 month ago

aalloilla commented 1 month ago

Concat also the failed ip-api.com responses so that missing columns will have null values. This way we'll keep the ip information at least for further stats if wanted. Will probably break some plotting functions. They will need checks for not operating on null values where applicable.

callumrollo commented 1 month ago

Passed the main tests, it's just failiing on the plots which I plan to factor out anyway. Looks good! I'll try to merge in a fix on the plots to green the tests, otherwise I'll just merge anyway