search

callumrollo / erddaplogs

Quick utilities for parsing nginx and apache logs for ERDDAP requests
MIT License
0 stars 4 forks source link

Addressing Issue #42, adding wildcard to log files access. #49

Closed aalloilla closed 1 month ago

aalloilla commented 1 month ago

Issue #42 fix suggestion.

callumrollo commented 1 month ago

Nice PR! A couple of things to fix:

  1. Make a wildcard_fname kwarg like df_nginx = _load_nginx_logs(nginx_logs_dir, wildcard_fname="*access.log*") with a sensible default. This way it should run as standard (and also won't trip up the tests!)
  2. Don't run jupyter notbooks before commiting, it adds a lot of noise to the PR and a lot of unneeded baggage to git history, especially when generating images
callumrollo commented 1 month ago

Almost! Want the kwarg in the class definition line: def oad_nginx_logs(self, nginx_logs_dir: str, wildcard_fname="*access.log*")

My bad, I wrote it in the wrong line in the example I gave in my last comment ><

callumrollo commented 1 month ago

You should be able to run pytest locally too to test out changes before commiting

aalloilla commented 1 month ago

Sorry didn't get to run the tests locally. I have been too distracted by other things honestly. Thank you for your patience!

callumrollo commented 1 month ago

This resolved #42