search

callumrollo / glidertest

Diagnostic test of glider data quality and required processing
MIT License
0 stars 3 forks source link

Prepare for tests #19

Closed MOchiara closed 3 months ago

MOchiara commented 3 months ago

Ok I feel like I made a but of a mess before and now I cant undo it @callumrollo

callumrollo commented 3 months ago

Looks fine! Now you just need to add some tests. Try to get them to run locally before committing, then we can work on stuff like github actions to run them automatically

MOchiara commented 3 months ago

@callumrollo ok I should have added all. I used the same functions you suggested, worked fine when I tested it locally

MOchiara commented 3 months ago

Should we do the workflow separately?

callumrollo commented 3 months ago

nah add that in too, get it all done in one :)

MOchiara commented 3 months ago

@callumrollo windows and mac tests are super slow, do we want to keep them anyways?

callumrollo commented 3 months ago

It's good to test against a wide range of systems. We should ideally get to the bottom of this. I'll see if they also are slow on #16 otherwise we can remove the windows and mac tests for now

MOchiara commented 3 months ago

Sounds good! Let's see how it runs on the other one

MOchiara commented 3 months ago

Why is mine so slow?

MOchiara commented 3 months ago

Wohooooo!