search

callysto / callysto-sample-notebooks

Other
1 stars 13 forks source link

American Revolution Notebooks require Plotly #1

Open colliand opened 6 years ago

colliand commented 6 years ago

ekce commented 6 years ago

Was this resolved by adding plotly to the callysto-setup script? If so then perhaps the script should emit a message reminding users to make sure their plotly api key is configured?

If there are plans to change the way dependencies are handled in general then maybe this issue should be re-purposed to keep track of uncommon dependencies (like tweep used in the Twitter notebook).

davidichan commented 6 years ago

We had initially patched the plotly dependency by adding it to the callysto-setup script, that's correct. Since then, the hub has been rebuilt and makes plotly available to all users by default since it's such a commonly used library. I will go ahead and remove it from the setup script now. With regards to the api key, I don't think users in general will need keys. My understanding is keys are only needed if you want to store plots online or use any of the services that require sign-in. If you run the notebooks without an api key, things should still execute.

As for how to keep track of dependencies, I think we need to provide clearer instructions in the training manual for a standardized way of handling those. i.e we need to agree on how those dependencies are taken care of, either across the hub or installed as part of a notebook or a script that is called from the notebook.