search

callysto / callysto-sample-notebooks

Other
1 stars 13 forks source link

American Revolution is broken - Plotly issues? #11

Closed mlamoureux closed 5 years ago

mlamoureux commented 5 years ago

The new version of the American Revolution notebook is broken. Geographic_progression_American_revolution The issue seems to be that plotly is unable to plot the data table in the section "The Progression of the War." The error message that I get is summed up by "ValueError: Invalid property specified for object of type plotly.graph_objs.Table: 'type' " This seems to be either in the creation of the table, or the execution of iplot.

I'm wondering -- who created this new version, and is it working for them? It doesn't work for me.

AlexIsBadWithComputers commented 5 years ago

Should be fixed. See here: https://github.com/callysto/callysto-sample-notebooks/commit/12546778c9ed4c77ff11be9add15ff1a8fb147b9#diff-a061b93a67dd584904d8d00462c42e10

Specifically the commented out type = 'table'