search

calmackenzie / VG1819

Final Project for CS4830 2018 - 2019
0 stars 2 forks source link

Crash from hovering units in hand #431

Closed calmackenzie closed 5 years ago

calmackenzie commented 5 years ago

I believe this is a demon/ancients crash: Specific deck used: Eldritch Lord as commander 2x each unit starting with "Eternal Eye"

Reproduction steps:

  1. Enter testing grounds with above deck
  2. Hover over cards in hand
  3. If no crash, end turn
  4. Repeat 2-3
  5. Crash

Callstack: image

CardContext's text was "Gorefiend" image

m_unitData was null ? image

Crash was from trying to getComponent on null gameObject from m_unitData

calmackenzie commented 5 years ago

The crashing player had two gorefiends in hand at time

calmackenzie commented 5 years ago

Might be triggered from hovering over one of them?

calmackenzie commented 5 years ago

Ok, (sorry for flooding comments) the crash is from hovering cards in the hand, updating issue as result

kamarapala commented 5 years ago

I'm taking a look at it since it concerns CardContext/StatusIcons

kamarapala commented 5 years ago

Issue was that a flag to indicate to update by GO or by ID in CardContext was being set after the unit was set. This should have caused problems for all units, but it seemed to only cause problems for Gorefiend and I couldn't figure out why only that card.

Regardless, I have a fix that sets those flags before setting the units.