Servant Sacrifice did not reduce cost of a unit.

calmackenzie / VG1819

Final Project for CS4830 2018 - 2019

0 stars 2 forks source link

Servant Sacrifice did not reduce cost of a unit. #463

Closed austinbrianrogers closed 5 years ago

austinbrianrogers commented 5 years ago

Forgot to grab a picture. I will post one if it happens again during testing.

SRJYC commented 5 years ago

not fixed by #475

calmackenzie commented 5 years ago

My bad, tagged the wrong issue in the PR D:

SRJYC commented 5 years ago

Sacrifice will reduce cost, but the card on hand will not update, at least this what in test ground.

I have 1 resource. Normal card. Can't summon.

But another card can. Its cost is reduced.

But I found another bug, that it will make next unit can't take action. I am fixing it.

SRJYC commented 5 years ago

When you hover on the card, the card context is updated by Id, so it will not show any changes in hand. I have no idea to fix it. @austinbrianrogers

kamarapala commented 5 years ago

I'm taking a look at it.

I'm pretty sure that early on, the cards had unit components that weren't attached to GOs, so I had to update them by ID. Now they are attached to the card GO, so we should be able to update cards in hand by GO as well, which would update the cost as well

kamarapala commented 5 years ago

Seems to work. I'll put up a PR shortly