search

calmh / node-snmp-native

Native Javascript SNMP library for Node.js
MIT License
252 stars 66 forks source link

Fixed minor OID validation bug #27

Closed justinsvegliato closed 9 years ago

justinsvegliato commented 9 years ago

Please note that I kept most of the else-if statement because the check oid[0] !== 1 is correct since every OID must start with a 1. I've adapted the tests accordingly.

justinsvegliato commented 9 years ago

Have these changes been published to NPM yet?

calmh commented 9 years ago

They have now. Sorry, forgot about it.

justinsvegliato commented 9 years ago

Thanks for pushing it out! It's appreciated. On Mon, Apr 6, 2015 at 3:24 PM Jakob Borg notifications@github.com wrote:

They have now. Sorry, forgot about it.

— Reply to this email directly or view it on GitHub https://github.com/calmh/node-snmp-native/pull/27#issuecomment-90204940.