search

calne-ca / subsonic-java-client

A Java Client for the Subsonic API
GNU General Public License v3.0
2 stars 0 forks source link

getArtistInfo2 #5

Closed esiqveland closed 2 months ago

esiqveland commented 3 months ago

Hey, would you consider adding these methods as well?

Thank you for the very helpful library!

calne-ca commented 2 months ago

I'll try to do that this week

calne-ca commented 2 months ago

I've implemented these methods in the latest release 0.5.0. The getArtistInfo / getAlbumInfo operations are hard to test since Subsonic depends on an external system (Last.FM) for those. If you face any issue feel free to create a new issue and I'll provide a bugfix release.

esiqveland commented 2 months ago

Nice!

I think these Params classes need to be public, otherwise I can not use them: https://github.com/calne-ca/subsonic-java-client/blob/master/src/main/java/net/beardbot/subsonic/client/api/lists/AlbumListParams.java

calne-ca commented 2 months ago

Ah, probably was a copy paste issue, since there are internal param classes as well. I've fixed it and put the changes into a new release 0.5.1