search

calo001 / luna

📆 Calendar Widget for Linux desktop
GNU Affero General Public License v3.0
29 stars 6 forks source link

Shadow on non-transparent themes? #1

Closed cassidyjames closed 5 years ago

cassidyjames commented 5 years ago

Right now the applet looks a little bit off without any shadow on the colored themes. It makes sense to remove the shadow when it's transparent, but I think keeping it with the colored themes would look a bit more native to elementary OS.

calo001 commented 5 years ago

Originally, my idea was to have a shadow according to the color of the calendar, however I did not find a suitable configuration of values in box-shadow that I would like very much and that would be similar to the one used by elementary OS. So I decided to put a small shadow around, but I'll try to see if I can make it look more native.

One of the problems that I found when using the box-shadow by default is shown in the following image. In the first it felt that the upper white border does not look very nice and in the second the black border when the dark mode is enabled in the system.

calendarissue

cassidyjames commented 5 years ago

"dark mode" isn't something that elementary OS natively supports unless your app requests it, so I wouldn't be to concerned about the second screenshot. The first looks close to correct to me. You might look at Dan's styling in Nimbus for some inspiration, though.

calo001 commented 5 years ago

I realized that the key is to use @define-color bg_highlight_color shade (@color, 1.4); that way the border looks prettier and more native to elementary. Soon an update :smile: