search

calogica / dbt-date

Date-related macros for dbt
Apache License 2.0
230 stars 64 forks source link

Add Trino support #115

Closed damian3031 closed 1 year ago

damian3031 commented 1 year ago

resolves #114

I'm not sure if I've set up CircleCI properly, as I'm not familiar with it. Your assistance would be greatly appreciated 🙂

clausherther commented 1 year ago

Thanks! Let me look over this over the weekend and think about whether we want to get into supporting Trino in our repo.

clausherther commented 1 year ago

FYI, CI is failing on the docker container https://app.circleci.com/pipelines/github/calogica/dbt-date/138/workflows/ae42adc3-3f8f-4733-8bfa-a3e181cc2901/jobs/151/parallel-runs/0/steps/0-106

In my experience, debugging CircleCI or any CI is a major pain which is why that's been the biggest blocker for adding new platform support.

clausherther commented 1 year ago

@damian3031 CI still erroring out https://app.circleci.com/pipelines/github/calogica/dbt-date/139/workflows/d624876c-ff97-43c3-92e2-70b5724d13a8/jobs/157/parallel-runs/0/steps/0-107

damian3031 commented 1 year ago

@clausherther I've set up CircleCI in my fork and made sure that the CI is passing. There shouldn't be any errors now.

clausherther commented 1 year ago

Looks good. I think you need a rebase to resolve those conflicts and then we're good to go!

clausherther commented 1 year ago

Looks good. I think you need a rebase to resolve those conflicts and then we're good to go!

nm, looks like you did already ;)

damian3031 commented 1 year ago

Awesome! Thanks for releasing it quickly!