calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
1.06k stars 130 forks source link

Fix missing group_by default value in string_matching macros #126

Closed samantha-guerriero-cko closed 2 years ago

samantha-guerriero-cko commented 2 years ago

Fix for issue #125.

Problem: All the methods in macros/schema_tests/string_matching/ define a group_by_columns=group_by functionality, but group_by is not defined in the method which makes them fail with 'MacroGenerator' object is not iterable.

Solution: we set group_by = None as it's not used by the method.

clausherther commented 2 years ago

@samantha-guerriero-cko thanks for the super quick turnaround here! Will do a release later today, but may take a bit before it shows up on the dbt package hub.

samantha-guerriero-cko commented 2 years ago

thank you @clausherther 💪