calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
1.06k stars 130 forks source link

Redundant set definition + Feature request in `expect_multiculumn_sum_to_equal` #129

Closed Gregory108 closed 2 years ago

Gregory108 commented 2 years ago

https://github.com/calogica/dbt-expectations/blob/d7f98601811db2532510a70103f66f9784bc979c/macros/schema_tests/multi-column/expect_multicolumn_sum_to_equal.sql#L9

Why would we need this set that is not used?

Also, is it possible to implement this test:

clausherther commented 2 years ago

hi @Gregory108, thanks for bringing this up, that operator is a copy & paste issue, easy fix.

If you'd like to add new tests to the repo, feel free to submit a PR (or a more specific issue if you'd like more feedback first)! 👍