calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros

https://calogica.github.io/dbt-expectations/

Apache License 2.0

1.06k stars 130 forks source link

Added partition by in lag tests #146

Closed Lucasthenoob closed 2 years ago

Lucasthenoob commented 2 years ago

Problem:

Not possible to put partition by parameters in the following tests:

expect_column_values_to_be_increasing
expect_column_values_to_be_decreasing

Changes:

Added an optional parameter which allow to partition by.
Updated the README.MD with accordingly

Please let me know if there is anything

clausherther commented 2 years ago

Thanks @Lucasthenoob! Will look over this over the weekend.

Lucasthenoob commented 2 years ago

It should be good now. Sorry I don't have dbt installed on my personal computer. I validated the test is working on my other one but I could not test the second commit: data creation and test implementation