search

calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
1.06k stars 130 forks source link

expect_column_value_lengths_to_be_between doesn't work with a column name as a reserved keyword #150

Closed tevariou closed 2 years ago

tevariou commented 2 years ago

expect_column_value_lengths_to_be_between doesn't quote the column name. If the column name is a reserved keyword (such as offset, start, etc... with pg), the test fails.

clausherther commented 2 years ago

Thanks for raising this issue @tevariou! Should be a fairly easy fix. We quote in some cases, but not consistently everywhere. Are you interested in submitting a PR for this? Happy to help!

tevariou commented 2 years ago

Thanks for raising this issue @tevariou! Should be a fairly easy fix. We quote in some cases, but not consistently everywhere. Are you interested in submitting a PR for this? Happy to help!

Thanks! Here it is #152