Add expect_column_distinct_count_to_be_less_than.sql

calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros

https://calogica.github.io/dbt-expectations/

Apache License 2.0

1.06k stars 130 forks source link

Add expect_column_distinct_count_to_be_less_than.sql #193

Closed dylanrigal closed 2 years ago

dylanrigal commented 2 years ago

expect_column_distinct_count_to_be_less_than.sql is a copy of expect_column_distinct_count_to_be_greater_than.sql, but with "<" instead of ">"
README.md is updated to reflect addition

clausherther commented 2 years ago

Hi @dylanrigal thanks for this PR! Could you also please add an integration test in integration_tests/models/schema_tests/schema.yml ? Let me know if you need help with that.

dylanrigal commented 2 years ago

Hi @dylanrigal thanks for this PR! Could you also please add an integration test in integration_tests/models/schema_tests/schema.yml ? Let me know if you need help with that.

Hi Claus, thanks for reviewing. I just added an integration test in the specified location. Let me know if there is anything else to add.

clausherther commented 2 years ago

@dylanrigal great, thanks! I also added a version with row_condition. I'll run the tests and will likely merge to main today. Not sure yet when I'll cut a new release though, but won't be that far off. Is this something you need in a release urgently?

dylanrigal commented 2 years ago

@clausherther Thanks for merging. No it isn't urgent, but looking forward to the next release.