search

calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
1.04k stars 126 forks source link

Fix boolean logic in `expect_compound_columns_to_be_unique` `ignore_row_if` #202

Closed clausherther closed 1 year ago

clausherther commented 1 year ago

Fixes #200

This fixes the implementation of the ignore_row_if parameter in expect_compound_columns_to_be_unique highlighted by @mcannamela in #200 and adds a test to data_test.

clausherther commented 1 year ago

I also had the thought, is it possible that this logic shows up in other expectations? I didn't investigate this at all.

I'll take a look, good call out. If so, I'll open a separate issue/PR though.