calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
1.01k stars 123 forks source link

Wrong Description of Default Behaviour #229

Closed praveen-prashant closed 1 year ago

praveen-prashant commented 1 year ago

In the REAMDE.md it says that quote_values is false by default for expect_column_distinct_values_to_contain_set. However, that is not true. It is true in the code

image image

https://github.com/calogica/dbt-expectations#expect_column_distinct_values_to_contain_set

https://github.com/calogica/dbt-expectations/blob/main/macros/schema_tests/aggregate_functions/expect_column_distinct_values_to_contain_set.sql

clausherther commented 1 year ago

Good catch, thanks.