search

calogica / dbt-expectations

Port(ish) of Great Expectations to dbt test macros
https://calogica.github.io/dbt-expectations/
Apache License 2.0
989 stars 120 forks source link

Update calogica/dbt_date version. #277

Closed eivl closed 10 months ago

eivl commented 10 months ago

During maintenance update to dbt-expectations version 0.9.0 I get an message about dbt_date having an update available.

image

I think it does not update itself due to this:

packages:
  - package: calogica/dbt_date
    version: [">=0.8.0", "<0.9.0"]

Now in my mind, updating the underlying package would work. However #271 did an update a few weeks ago and I'm not sure its safe to just update the dbt_date package. I have tested this myself without finding any issues during install.

My suggestion is to just do it like so:

packages:
  - package: calogica/dbt_date
    version: [">=0.9.0", "<0.10.0"]

I made an PR #278 with this change, would love some feedback if this is correct or not.

clausherther commented 10 months ago

Hi, this is intentional, please see #275