search

calonso / ios-arkit

iOS Location based Augmented Reality engine
https://github.com/calonso/ios-arkit
MIT License
87 stars 35 forks source link

Overlap #4

Closed Sneakr closed 7 years ago

Sneakr commented 8 years ago

Hello,

First I want to thank you for good project! I am a fairly beginner, and my question is, do you have any good guidance/solution for overlapping objects behind eachother? For example, maybe put then above or generate a list or something?

Thank you for any advice and support!

calonso commented 8 years ago

Hi there... IIRC they're overlapped based on proximity, so the closest is first in the line. On the other hand I see your point but I have nothing in mind, maybe you feel like adding something to the engine? That would be great!!

On the other hand, glad you find the project useful!

Sneakr commented 8 years ago

Hi, thanks for response! I am trying to figure out something checking around the forums, I have just started coding in iOS , If I find anything useful or solution ill add it! cheers

Sneakr commented 8 years ago

Actually I managed to make a small fix to the radar view:

if (_points.count != _dotsView.subviews.count) { point = [[UIImageView alloc] initWithImage:[UIImage imageNamed:@"smAugmentedRealityDot"]]; [_dotsView addSubview:point]; } else { point = [_dotsView.subviews objectAtIndex:count]; }

Instead of recreating and allocating new uiimageviews you just move position of existing one.

calonso commented 8 years ago

Can you open a pull request with your proposal along with some images on the final result?

Thanks!

Sneakr commented 8 years ago

I am a newbie at github and this was my first pull request. I hope I have done everything correctly ! It seems good tho I think :)

calonso commented 8 years ago

Great work @Sneakr. I've reviewed it and left a couple of minor comments.

Thank you very much!

Sneakr commented 8 years ago

Cool, Im glad I was of use, I commented on your changes how I was thinking when I set it up that way.

Cheers