search

calonso / ios-arkit

iOS Location based Augmented Reality engine
https://github.com/calonso/ios-arkit
MIT License
87 stars 35 forks source link

Memory/Cpu improvement #5

Open Sneakr opened 8 years ago

Sneakr commented 8 years ago

Changed bad recreation of UIImageViews on every movement frequency cycle and saves performance.

calonso commented 8 years ago

Hi @Sneakr how are you doing with this? Do you need any help? Come on, just one more effort and we'll get this merged!

Sneakr commented 8 years ago

@calonso hey, I asked what to do to get this merged , maybe you miseed that message, this is my first pull request if you can point me in direction I can finish it of course, not sure what to do from here lol!

calonso commented 8 years ago

Ok, so the way this works is that normally you go through my comments fixing them, commit and push changes again, I review and make comments and so on until we get to a point where we are both happy with the final result and we merge it. Hopfeully it won't take very long to get to this point as your changes are quite good already and my comments are just minor ones.

calonso commented 7 years ago

Hey @Sneakr how are you doing? Do you need any help with this? I really like your work, just a few fixes and we'll get it merged!

Sneakr commented 7 years ago

Hey man, Sorry for the delay im not very active, This github interface really makes me dizzy, my I get brainfreeze from everything here, you are free to just copy the edits and make the improvments as you wish and merge it!

calonso commented 7 years ago

That's a pity man, we were so close, just a couple of minor comments... I'll keep it here should you find energy in the weekend ;)