Added certificate password phrase to apns configuration

calonso / rails-push-notifications

Rails iOS, Android and Windows Phone Push Notifications made easy!!

https://rubygems.org/gems/rails-push-notifications

MIT License

139 stars 42 forks source link

Added certificate password phrase to apns configuration #1

Closed sendorf closed 10 years ago

sendorf commented 10 years ago

Hi,

I have added the certificate password phrase to APNS configuration, so that it doesn't have to be blank. It can be set in APNS configuration, using

app.apns_cert_pass = 'my pass phrase'

calonso commented 10 years ago

Hi Sergio. I like the idea of being able to use password protected certificates but just a couple of improvements before merging:

Why did you renamed the migrations?
Please, add the new field as a new migration rather than modifying the older migration. For projects already using it will be easier to upgrade.
Please make sure that no password certificates are still usable.

Regards

sendorf commented 10 years ago

I renamed the migrations because with the 001 and so names you cannot revert the migration with the script

rails destroy ror_push_notifications:migrations

And you are right about creating a new migration instead of modifying the old one for people upgrading the gem.

And also you are right about the gem already using the password protected certificates, it uses them and there's no need of storing it, I have revised the code and I am not using the certificate password at all.

Sorry for making you lose your time.

Regards!.

calonso commented 10 years ago

No worries, thanks anyway for thinking of contributing!! I'll be glad to have any contributions.

Regards!