search

calpaterson / csvbase

a simple website for sharing table data - with an API
https://csvbase.com
GNU Affero General Public License v3.0
376 stars 13 forks source link

Merge export endpoints into table_view_with_extension #105

Closed equirke closed 7 months ago

equirke commented 7 months ago

Hello, Merges the functions export_table_csv and export_table_xlsx and their routes into table_view_with_extension. Modifies the table_export and table_macros templates to generate their links using the routing linked to table_view_with_extension using the extension parameter.

Both . and /export/\<extension> are available but the links in the html pages seem to always be built using the /export/\<extension> format regardless.

calpaterson commented 7 months ago

I was able to build on your work in https://github.com/calpaterson/csvbase/commit/faa123aeefe8451ae38cb5ead9332ad3b1b23453

I'll try to take a look at seeing if we can get the website to use the {username}/{table_name}.{extension} urls and that would be nice I think.

Tell me what you think about setting content-disposition and making the browser download the file. I am not 100% on whether I like that.