Bookmark CRDT is not total

[calpaterson]

Description

Bookmark CRDT covers nearly all cases but not everything - sometimes merges are not commutative.

Steps to reproduce

1. Two bookmarks A and B with same updated time but other differing features
2. Merge A with B to create C
3. Merge B with A to create D

Expected result

C == D

Actual result

C != D

Additional details

The problem occurs in this code:

        more_recent: "Bookmark" = sorted(
            (self, other),
            # The below lambda should include all fields for which more_recent is consulted
            # ie, everything other than created and updated
            key=lambda b: (
                b.updated,
                len(b.title),
                len(b.description),
                b.title,
                b.description,
            ),
            reverse=True,

        return Bookmark(
            url=self.url,
            created=min((self.created, other.created)),
            updated=max((self.updated, other.updated)),
            title=more_recent.title,
            description=more_recent.description,
            unread=more_recent.unread,
            deleted=more_recent.deleted,
        )    )[0]

[calpaterson]

Fixed in 11a930062513926e98b34ef34dd7ac1f558d1736

[calpaterson]

Reopening as it's not been fixed in the extension

[calpaterson]

Pretty sure this issue is fixed but need to confirm it

[calpaterson]

Review the code, extension differs slightly and needs to be brought into line: https://github.com/calpaterson/quarchive/issues/57