calpaterson / quarchive

Traditional "Web 2.0" social bookmarking, with small improvements
https://quarchive.com/
GNU Affero General Public License v3.0
100 stars 6 forks source link

Bookmarks created by a fullSync fire browser.bookmarks.onCreated #5

Closed calpaterson closed 4 years ago

calpaterson commented 4 years ago

Description

Bookmarks created by a fullSync seem to fire the onCreated event which throws exceptions because the bookmark already exists in the local db, slowing down the process considerably.

Steps to reproduce

  1. Have a bookmark on the server that doesn't exist locally
  2. Do a full sync
  3. Watch the console

Expected result

Process completes quickly with no errors

Actual result

Lots of errors, slowing down the full sync considerably.

Additional details

image

calpaterson commented 4 years ago

Resolved: listeners are disabled while fullSync is going on.