search

calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.
https://nimbus.api.calpolycsai.com/
GNU General Public License v3.0
9 stars 4 forks source link

Raw course strings joined with commas #102

Closed cameron-toy closed 4 years ago

cameron-toy commented 4 years ago

Describe the bug When retrieving many answers related to courses, words are comma separated instead of space separated.

To Reproduce Hit the /ask endpoint with "What are the prerequisites for CPE 357?"

Returns:

"The prerequisites for CPE 357 are: CSC/CPE,102,and,CSC/CPE,103,with,a,grade,of,C-,or,better,or,consent,of,instructor,,or,CSC/CPE,202,and,CSC/CPE,203,with,a,grade,of,C-,or,better,or,consent,of,instructor;,and,CSC,225,or,CPE/EE,229,or,CPE/EE,233..",

Expected behavior "The prerequisites for CPE 357 are: CSC/CPE 102 and CSC/CPE 103 with a grade of C- or better or consent of instructor, or CSC/CPE 202 and CSC/CPE 203 with a grade of C- or better or consent of instructor; and CSC 225 or CPE/EE 229 or CPE/EE 233."

This is due to how words are joined across multiple lines in the course scraper in the csai-scraping repo. I'll push a fix by the end of today.

cameron-toy commented 4 years ago

Pull request has been merged. However, someone still needs to update the data with the scraping sustainer.