Remove last raw_data_dict reference - Githubissues

calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.

https://nimbus.api.calpolycsai.com/

GNU General Public License v3.0

9 stars 4 forks source link

Remove last raw_data_dict reference #106

Closed Jason-Ku closed 4 years ago

Jason-Ku commented 4 years ago

What's New?

stray raw_data_dict reference replaced with data_dict. Should prevent the api from crashing if trying to save an AudioSampleMetaData Entity.

Type of change (pick-one)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

sanity tested

Checklist (check-all-before-merge)

formatting help: - [x] means "checked' and - [ ] means "unchecked"

[ ] I documented my code according to the Google Python Style Guide
[ ] I ran ./build_docs.sh and the docs look fine
[ ] I ran ./type_check.sh and got no errors
[ ] I ran ./format.sh because it automatically cleans my code for me 😄
[ ] I ran ./lint.sh to check for what "format" missed
[ ] I added my tests to the /tests directory
[ ] I ran ./run_tests.sh and all the tests pass

Jason-Ku commented 4 years ago

I agree that this fix is necessary! Good catch @Jason-Ku !

Can we include, at least 1 new test case into the /tests/ folder

Including a new test will help to prevent this bug from occurring ever again.

Also, it’s good software engineering practice.

Run pytest and make sure that new test passes. Feel free to disregard other failing tests.

It will be equivalent to your

sanity test

Except this time, documented and committed.

The team has surely written many tests within __main__ by now. Let’s just make sure to save those tests.

For sure!