search

calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.
https://nimbus.api.calpolycsai.com/
GNU General Public License v3.0
9 stars 4 forks source link

Non-normalized chatbot responses #107

Open Jason-Ku opened 4 years ago

Jason-Ku commented 4 years ago

Describe the bug Non-normalized responses from chatbot - (not capitalizing the first letter of the sentence, uses whatever was typed in).

Bug severity Minor, non-blocker, purely aesthetic.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://nimbus.calpolycsai.com/
  2. Submit "What is kurfessss's phone number?" as a question and hit send
  3. Wait for a response
  4. See non-normalized response (will respond with kurfessss's phone number is xxx)

Expected behavior I expected the output response to be normalized / "correct"

Screenshots If applicable, add screenshots to help explain your problem. image

Additional context Should be a pretty easy fix - famous last words from @cameron-toy (but in all actuality, it should be - just need to return the normalized Entity name in the output)

cameron-toy commented 4 years ago

Unfortunately, it won't be quite as easy as returning the normalized Entity name. The normalized Entity is just the Entity string without titles (Professor, Dr., etc). To actually get a normalized name, we'll have to modify the db_query and format_answer methods for each QA object.

We'd also have to find a way to describe how to identify each type of entity. For example, professor names could be normalized as "Professor {last_name}" or as "{first_name} {last_name}"

More and more I'm feeling like we should have some sort of single "identifying_name" column for each entity.