calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.
https://nimbus.api.calpolycsai.com/
GNU General Public License v3.0
9 stars 4 forks source link

Dependency removal #110

Closed cameron-toy closed 4 years ago

cameron-toy commented 4 years ago

EDIT: Feature list is different between the two versions, probably due to different lemmatization rules and stopword lists between NLTK and spacy. Hold off on merging until more testing is done.

What's New?

Type of change (pick-one)

How Has This Been Tested?

QuestionClassifier was tested on its own with a variety of inputs against the original QuestionClassifier to make sure they provided the same output. Also, end-to-end tests were performed at the end and seemed to work fine, answering several questions.

Checklist (check-all-before-merge)

formatting help: - [x] means "checked' and - [ ] means "unchecked"

mfekadu commented 4 years ago

@cameron-toy I agree with @Jason-Ku. Once the conflicts are resolved, I believe the tests will pass, and then we can merge this in!

mfekadu commented 4 years ago

Closing due to #136 including these changes