Closed Waidhoferj closed 4 years ago
Shoutout to @snekiam for figuring out that the settings.yml file was failing because it should be settings.yaml
I ran ./format.sh because it automatically cleans my code for me 😄 (which is why like 27 files were touched)
I'll approve this PR after we merge #121 first. I suspect some merge conflicts in our near future because ./format
ran there too. Although, maybe not since the black
autoformatter is deterministic/has-same-outputs-every-time and thus might make this merge a lot smaller. ¯\_(ツ)_/¯
let's see what happens.
Thanks for running it, I've been reluctant to do so for some time. It needed to happen
Just rebased from dev. Though Github is still mad for some reason, this branch should now be up to date.
@Waidhoferj
Hmm... did you make sure to git push
your changes?
If so, then I suppose quickly fixing the conflicts through the GitHub UI should suffice. I’d change them myself but I think you have a better idea of the logic right now.
The conflicts seem small
@snekiam the entire path and function was duplicated 😅. Nice catch!
oh wow. these conflicts are scary
Ik 😅. I'll handle it.
Farewell old friend, we knew ye well.
What's New?
While the audio files have been uploaded from the web app to G Drive for some time, the metadata wasn't being logged in the sql server. That's fixed now.
Also
emphasis
andscript
fields to AudioSampleMetadatafilename
withaudio_file_id
, which will be far more useful for retrieving it from G DriveType of change (pick-one)
How Has This Been Tested?
I used postman to deliver a payload with a similar format as the example in the database_wrapper docstring. I also ensured that the formatted results propagated to the sequel server.
Checklist (check-all-before-merge)
formatting help:
- [x]
means "checked' and- [ ]
means "unchecked"./format.sh
because it automatically cleans my code for me 😄 (which is why like 27 files were touched)