Closed Jason-Ku closed 4 years ago
Still having some issues with validate_and_format_entity_data
. Running full integration tests with the scrapers to try to get everything resolved and will update the PR.
Hmm, what kind of issues?
If it's with something to do with the question answer pairs, it looks like someone added a custom method for formatting QA data so that may be a lead for you to look at.
What's New?
Quick fix to update flask app to use
insert_entity
method instead of old save_x methods, should get @austinsilveria up and runningType of change (pick-one)
How Has This Been Tested?
Ran unittests, but I don't have any concrete tests for the flask app so they don't mean much
Checklist (check-all-before-merge)
formatting help:
- [x]
means "checked' and- [ ]
means "unchecked"[ ] I documented my code according to the Google Python Style Guide
[ ] I ran
./build_docs.sh
and the docs look fine[ ] I ran
./type_check.sh
and got no errors[ ] I ran
./format.sh
because it automatically cleans my code for me π[ ] I ran
./lint.sh
to check for what "format" missed[ ] I added my tests to the
/tests
directory[x] I ran
./run_tests.sh
and all the tests pass