search

calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.
https://nimbus.api.calpolycsai.com/
GNU General Public License v3.0
9 stars 4 forks source link

Remove 'q_a_pairs.csv' and the reference to it, replace it with the answerable_questions API call #132

Open richagadgil opened 4 years ago

richagadgil commented 4 years ago

https://github.com/calpoly-csai/api/blob/b5bde1447021700c0e1dbc4907b867f391bf3c18/QA.py#L190

Remove q_a_pairs.csv and the reference to it, replace it with the answerable_questions API call. See #131 to see how answerable_questions api is used to populate dataframe.

mfekadu commented 4 years ago

@richagadgil does #131 take care of this issue?

richagadgil commented 4 years ago

No, this issue is requesting @cameron-toy to replace his use of the q_a_pairs.csv with an API call to answerable_questions when possible. He can use my code as a reference because it does the same thing :)

richagadgil commented 4 years ago

Then hopefully we can remove q_a_pairs.csv from the api repo

cameron-toy commented 4 years ago

@richagadgil This has been resolved right?