Updated workflow to use secret, cron now outputs reasonably - Githubissues

calpoly-csai / api

Official API for the NIMBUS Voice Assistant accessible via HTTP REST protocol.

https://nimbus.api.calpolycsai.com/

GNU General Public License v3.0

9 stars 4 forks source link

Updated workflow to use secret, cron now outputs reasonably #191

Closed snekiam closed 3 years ago

snekiam commented 3 years ago

What's New?

Use the INSTANCE_NAME from secrets to deploy to gcp. Updated the cron to update SSL certs to output to stdout, which is logged by docker

Fixes (works toward) #188

Type of change (pick-one)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

This doesn't change the way the api runs locally, it'll have to be tested on deploy.

Checklist (check-all-before-merge)

formatting help: - [x] means "checked' and - [ ] means "unchecked"

[ ] I documented my code according to the Google Python Style Guide
[ ] I ran ./build_docs.sh and the docs look fine
[ ] I ran ./type_check.sh and got no errors
[ ] I ran ./format.sh because it automatically cleans my code for me 😄
[ ] I ran ./lint.sh to check for what "format" missed
[ ] I added my tests to the /tests directory
[ ] I ran ./run_tests.sh and all the tests pass

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information