search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
173 stars 42 forks source link

Speed icon shown in party window when speed is not in any abnormal state #230

Closed x-qq closed 3 weeks ago

x-qq commented 4 years ago

As seen on an unrelated screenshot at https://0x0.st/zh0V.png

Original Exile 3 and Blades of Exile did not show the icon when there was no haste/slowness applied.

I personally find those icons distracting/disorienting (icons in party window usually meant some abnormal state that needs attention).

Could be made into a setting maybe?

CelticMinstrel commented 4 years ago

Marking as a bug because original BoE didn't use this icon either on Mac or Windows (though Exile II did use it).

NQNStudios commented 1 month ago

@CelticMinstrel I don't understand... couldn't you have made this refactor without introducing a regression and re-opening an issue?

I really don't want the normal speed icon to exist. I could introduce a preference to enable/disable it, but I think the default should be that it be off. I don't think anyone wants a normal speed icon.

CelticMinstrel commented 1 month ago

The previous fix was incomplete, so I probably would've reopened it even if I hadn't done the refactor. I already have a commit to remove it again but I haven't pushed it because CI somehow broke.

NQNStudios commented 1 month ago

Okay, thanks for clarifying. 🙏

NQNStudios commented 1 month ago

I have reproduced the linux compiler error. I thought at first it was because of a const mismatch but that wasn't the case.

NQNStudios commented 1 month ago

Actually it might be a const error.

CelticMinstrel commented 1 month ago

That was my guess too, but when I looked at the code I couldn't see anything wrong, and it didn't happen on Mac, so I was stumped.

NQNStudios commented 1 month ago

I added a const in a different place and it recompiled everything which I thought was a good sign but then came out with the same error

CelticMinstrel commented 1 month ago

My other guess was that the new file is somehow not compiled on Linux, but that can't be right, can it? I dutifully added it to the SConscript, after all.

NQNStudios commented 1 month ago

It is getting compiled, but maybe not by one of the 2 editors?

NQNStudios commented 1 month ago

living.cpp, which the error is coming from, is compiled in this group:

party_classes = Glob("#src/universe/*.cpp")

damage.cpp is compiled in this group tools = SConscript("build/obj/tools/SConscript")

NQNStudios commented 1 month ago

but tools end up in common_sources....

CelticMinstrel commented 1 month ago

And so do party_classes…

EDIT: Ah, they actually don't, but they're still added in for all 4 builds.

NQNStudios commented 1 month ago

scons game=true and scons scenedit=true work fine. only scons pcedit=true fails.

NQNStudios commented 1 month ago

I don't want to think about why it works now but I fixed it.

NQNStudios commented 1 month ago

419