Multiple Scenario Editor crashes

[x-qq]

• Scenario -> Advanced -> "Import Outdoor Sector" and then canceling file selection dialog
• Scenario -> Advanced -> "Set Scenario Event Timers" and press "ok" without doing anything

[NQNStudios]

I'm guessing that the first crash in this list is fixed now along with #301

[NQNStudios]

I reproduced the second crash on Windows. It came with an error message:

[NQNStudios]

The crash also happens if you do set a scenario event timer.

[NQNStudios]

It's happening here: https://github.com/calref/cboe/blob/master/src/scenedit/scen.core.cpp#L3145

i + 1 is making it try to access time11, so I think it's an off-by-1 error.

[NQNStudios]

That was wrong, sorry. It's here: https://github.com/calref/cboe/blob/master/src/scenedit/scen.core.cpp#L3109

Looks like the UI allows editing 10 when there are 20 (there's a TODO at the location of my last comment indicating this) but the save function is trying to save out text fields from 20 controls.

[NQNStudios]

I think a stack widget could be added to hold 2 pages of fields for 10 events each.

[NQNStudios]

I'm guessing that the first crash in this list is fixed now along with #301

On this point I was also wrong. Windows and Linux both crash with an error message when you cancel the file browser to import outdoor sections AND import towns.

[NQNStudios]

This issue can be closed now.