Fix unclickable shop info icons

calref / cboe

Classic Blades of Exile

http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/

Other

168 stars 41 forks source link

Fix unclickable shop info icons #260

Closed x-qq closed 4 years ago

x-qq commented 4 years ago

Fixed unclickable shop icons by applying the same offset to event catching rects as is applied to the shop UI when it's being drawn in the main window.
Removed strange adjustment of mouse click coords in shop UI by (-5, -5) px.
Removed click_shop_rect function that was doing "click emulation" in shop UI. Rationale: 1) it was causing visual glitches, because 2) various widgets do not get to decide when .display() is called, since other drawables may not be ready
Removed unneeded shop scrollbar redraw call which may improve performance of that UI a bit

Fixes #247

CelticMinstrel commented 4 years ago

You've removed click_shop_rect for some reason and now draw_shop_graphics is neverr called with true, which if I understand correctly means the pressed effect when clicking will not occur. Can you fix this, please? Putting click_shop_rect back where it was would be the easiest way, but whatever way you prefer is fine too.