Item information window provides incorrect data about armors

x-qq commented 4 years ago

Untitled

The above screenshot shows Bronze Plate Armor which has level 9, protection 1, bonus 0.

https://github.com/calref/cboe/blob/master/rsrc/bases/bladbase/items.xml#L2421

    <item id="125">
        <variety>armor</variety>
        <level>9</level>
        <awkward>4</awkward>
        <bonus>0</bonus>
        <protection>1</protection>
        <pic>16</pic>
        <name>Plate Armor</name>
        <full-name>Bronze Plate Armor</full-name>
        <treasure>2</treasure>
        <value>350</value>
        <weight>130</weight>
        <properties />
        <description>
            <![CDATA[Plate armor is made from multiple large, interlocking plates. They offer superb protection due to their weight and rigidity. The same weight and rigidity also make them very hard to move in, however.]]>
        </description>
    </item>

The item info window incorrectly shows bonus 1.

CelticMinstrel commented 4 years ago

I think it was intentional on Jeff's part to display the Protection amount as the bonus. I'm not sure if it also shows an actual bonus though…

NQNStudios commented 1 year ago

Is this related to 68ef066dca17823ddf9b99f2de9c6e0902b0d6bf?

CelticMinstrel commented 1 year ago

No, it's not related. That commit determines the short descriptive text that displays beneath the items in the get dialog and in shops.

calref / cboe

Item information window provides incorrect data about armors #266