calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
173 stars 42 forks source link

Unreachable code in monster AI #282

Closed CelticMinstrel closed 3 years ago

CelticMinstrel commented 3 years ago
  if ((caster->m_d.health * 4 < caster->m_d.m_health) &&
      (get_ran(1, 0, 10) < 9))
    spell = emer_spells[level][3];
  else if ((caster->m_d.status[STATUS_HASTE_SLOW] < 0) &&
           (get_ran(1, 0, 10) < 7) &&
           (emer_spells[level][0] != SPELL_MONST_PRIEST_NO_SPELL))
    spell = emer_spells[level][0];
  else if ((friend_levels_near <= -10) && (get_ran(1, 0, 10) < 7) &&
           (emer_spells[level][1] != SPELL_MONST_PRIEST_NO_SPELL))
    spell = emer_spells[level][1];
  else if ((target_levels > 50 < 0) && (get_ran(1, 0, 10) < 7) && // <- This does not do what it looks like!
           (emer_spells[level][2] != SPELL_MONST_PRIEST_NO_SPELL))
    spell = emer_spells[level][2];
  else {
    r1 = get_ran(1, 0, 9);
    spell = caster_array[level][r1];
  }

Originally reported here.

CelticMinstrel commented 3 years ago

Whoops, I created this before checking. Turns out they were looking at the original code and it's already been fixed.