search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
167 stars 41 forks source link

[WIP] Fix 244b #309

Closed NQNStudios closed 1 year ago

NQNStudios commented 1 year ago

Still in progress--this PR will fix the second crash reported in #244 by adding an extra page of scenario event timers in the scenario editor so all 20 can be used.

The first 2 commits, cc18c56866fa0c90239789eb39c0ba4b931b0825 and 1c775da7d2fec3b711861bd4396e3a1181191cf4, fix bugs in cDialog that caused other issues which I didn't open tickets for:

1) text field controls inside stack widgets didn't become focused when clicked on. The tab key was the only way to focus them. 2) entering characters to a text field in a stack widget would cause a crash.

Those bugs could be observed by editing town details and trying to edit the 3 comment fields which are managed by a stack.

CelticMinstrel commented 1 year ago

Looks good so far.

NQNStudios commented 1 year ago

038baddb02a99c0c11b71723fd7296c450d019f4 declares the captures on the closure you pointed out.

26b6d92ec32ca77d329681e492bd4f97f52726e9 fixes 2 more places where cDialog wasn't aware of text fields in containers.

https://github.com/calref/cboe/pull/309/commits/b2ce1f18719cc21a7ffef4afacd958c252371304 actually adds the stack and page buttons to allow editing the other 10 scenario event timers. I've tested on Windows to make sure it works and preserves the values across the 2 pages.

Fixes part 2 of #244.