calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
167 stars 41 forks source link

New underground scenario: outdoor town entrance is wrong terrain #339

Closed NQNStudios closed 1 year ago

NQNStudios commented 1 year ago

imagen

imagen

NQNStudios commented 1 year ago

The default outdoor section of a new scenario in the editor looks like this. When you leave town, you can't get back in because it's a blocked terrain type, not a town entrance.

I think it goes wrong here: https://github.com/calref/cboe/blob/ca816995ba9da539ed08a568616fbf36bea8bde0/src/scenedit/scen.core.cpp#L3082

NQNStudios commented 1 year ago

Here are the terrains. Fire pit must be 232. imagen

There are 4 underground settlement terrains in the row below, but I don't know which one was the intended default.

CelticMinstrel commented 1 year ago

That would be because I added a bunch of extra terrains (to fill the empty spaces left by making roads and special spots be "fields" instead) and shifted the cave terrains up. I believe the intended terrain is the first cave town terrain, one down and to the left of the fire pit. You can probably verify this by opening the legacy base (under rsrc/legacy) and checking what terrain 232 is, though it wouldn't be the end of the world if we got it wrong.

That said, while we can certainly do a quick fix for this now, I think the correct fix in the long term is to use a different "base" scenario for an underground scenario. Then there would be no need to mod the terrain to make it be underground.

NQNStudios commented 1 year ago

That said, while we can certainly do a quick fix for this now, I think the correct fix in the long term is to use a different "base" scenario for an underground scenario. Then there would be no need to mod the terrain to make it be underground.

Right. Linking to issue #249