search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
167 stars 41 forks source link

Build fix redo #353

Closed NQNStudios closed 1 month ago

NQNStudios commented 1 month ago

This is a cleaner redo of the working build fixes from #352. I'd like to get it merged so I can rebase #351 onto it

This stops short of trying to fix the Mac library compatibility warnings, which I haven't figured out how to do yet.

Hopefully the Windows CI failure that was happening last night will go away when the CI runs today (it was a dependency download error that seemed outside of our control.)

NQNStudios commented 1 month ago

Ok, I noticed the windows error message said to try vcpkg update so I added that to install-deps.bat but it still doesn't work. I'm going to file an issue with vcpkg now.

CelticMinstrel commented 1 month ago

Is there anything wrong with me squashing this into a single commit once you have it working?

NQNStudios commented 1 month ago

Possibly a loss of operational knowledge in the steps one would take to fix these kinds of CI failures?

NQNStudios commented 1 month ago

I think I could squash them into 1 commit per operating system, with descriptions explaining how I figured out the problems and why I chose the fixes I did.

NQNStudios commented 1 month ago

Got everything from this cleaned up into #354