Closed NQNStudios closed 2 weeks ago
I can't get the 32-bit build to work locally despite quadruple-checking all the lib paths. The compiler isn't finding Zlib, but I'm 100% sure I have an x86 build of zlib installed where scons is checking for it. This is frustrating.
I want to suggest separating out some concerns.
Without the PR, we have these problems:
With the PR, the situation becomes:
I would suggest that we do this:
I struggle to imagine how it ever worked
I'm not certain that it ever worked. When I built on Windows, I (almost?) always used MSVC 2013, not scons.
I agree on points 1, 3, and 4. For point 2, I would like the installer generation uncommented, but it can be set to run only if explicitly requested (so, running scons
won't try to generate an installer, but running something like scons package
will).
I did all the things.
Is it okay to squash all of this into a single commit? And if so, do you want to write up a summarized commit message?
I'm pretty comfortable squashing all of this one without doing a summary. 🤷♀️
There's some messiness in this PR with trying things, reverting them, etc. It should probably all be squashed, but I can now make a build with scons on Windows that actually launches.