search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
174 stars 42 forks source link

Resolve TODO comments in the source code #400

Open CelticMinstrel opened 3 months ago

CelticMinstrel commented 3 months ago

This issue merely serves as a reminder that TODO comments exist. It should not be closed, unless no TODO comments remain.

NQNStudios commented 6 days ago

https://github.com/calref/cboe/blob/e2142158af2b4c4d801e75b325e2448db9eab28a/src/gfx/render_text.cpp#L145

I'm going to hazard a guess about this TODO comment. Some APIs render the bottom-left corner of text at the position you request. Others render the top-left corner at that point. Maybe BoE used to use the first kind of API and switched to the second type when dependencies were modernized?

CelticMinstrel commented 6 hours ago

Oh, that's interesting. I have no idea if that's the case, but it's something that could probably be checked. BoE originally used the QuickDraw API for drawing text. Now we use SFML+Freetype.