search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
174 stars 42 forks source link

Update README.md to address #462 #464

Closed NQNStudios closed 1 week ago

NQNStudios commented 2 weeks ago

Could be made more concise, and might not be git beginner-friendly enough, but I made some edits that should make our recurring problem stated in #462 less common by being extremely explicit and using bold/capitalized text and a heading.

CelticMinstrel commented 2 weeks ago

You can't use the vcpkg installation that comes with Visual Studio for these commands.

…huh? Why not?

NQNStudios commented 2 weeks ago

Vcpkg has two modes: manifest mode (which we use in the CI to lock the dependency versions) and classic mode (which we are telling people to use here). In Visual Studio 2022 Community edition I found out yesterday that they’ve disabled classic mode in the built-in vcpkg.

So an alternative here would be to change this instruction to tell them to use manifest mode. For some reason, we didn’t make that change in the docs when we made it in the CI. I don’t remember if there was a good reason.

On Tue, Nov 5, 2024 at 11:04 PM Celtic Minstrel @.***> wrote:

You can't use the vcpkg installation that comes with Visual Studio for these commands.

…huh? Why not?

— Reply to this email directly, view it on GitHub https://github.com/calref/cboe/pull/464#issuecomment-2458732186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATXBKJFZONSNGF2QY5SJGDZ7GPNZAVCNFSM6AAAAABRHAWVPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYG4ZTEMJYGY . You are receiving this because you authored the thread.Message ID: @.***>

NQNStudios commented 2 weeks ago

As it happens, I think the install command would get simpler, with a caveat that you must call it from inside proj/vs2017 or proj\vs2013.

C:\Users\natqu\repos\cboe\proj\vs2017>vcpkg install --triplet=x64-windows

And this would help us avoid new contributors getting a new version of boost that scons can't find.

NQNStudios commented 2 weeks ago

I'm gonna go ahead and make that change.