search

calref / cboe

Classic Blades of Exile
http://spiderwebforums.ipbhost.com/index.php?/forum/12-blades-of-exile/
Other
175 stars 42 forks source link

Intro/"Welcome to Blades of Exile" dialog has broken formatting #465

Closed NQNStudios closed 2 weeks ago

NQNStudios commented 2 weeks ago
Screenshot 2024-11-07 at 12 40 10 PM
NQNStudios commented 2 weeks ago

I thought that setting a frameStyle on each of the text widgets would shed some light on why the relative layouts are so busted. It definitely revealed that things are FUBAR, but I still can't see how the frames relate to the relative positioning -- it seems like the relative positioning is wrong and inconsistent even according to the frames.

WithOutlinesScreenshot

EDIT: Post-processing to make borders more visible.

NQNStudios commented 2 weeks ago

It's looking like I broke this when I optimized line breaking 😅

CelticMinstrel commented 2 weeks ago

I think what's happening here is that there is a mismatch between the code that calculates how much space is needed and the code that actually renders the text.

So that means that the height allotted by the calculation is overflowed when actually rendering, and as a result, the text overflows its bounds when rendering.

Since each text block is positioned relative to the previous one, we would need to fix the calculation.

NQNStudios commented 2 weeks ago

That’s the track i’m on.

On Sat, Nov 9, 2024 at 1:45 PM Celtic Minstrel @.***> wrote:

I think what's happening here is that there is a mismatch between the code that calculates how much space is needed and the code that actually renders the text.

So that means that the height allotted by the calculation is overflowed when actually rendering, and as a result, the text overflows its bounds when rendering.

Since each text block is positioned relative to the previous one, we would need to fix the calculation.

— Reply to this email directly, view it on GitHub https://github.com/calref/cboe/issues/465#issuecomment-2466426867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATXBKJTP57FZJ6LSEH4U33Z7ZQ7PAVCNFSM6AAAAABRL3V776VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGQZDMOBWG4 . You are receiving this because you authored the thread.Message ID: @.***>