search

calrissian / mango

Common utilities for rapid application development
Apache License 2.0
17 stars 7 forks source link

Rename Tuple to some other class since the current Tuple is really not a tuple by definition #142

Closed cjnolet closed 9 years ago

cjnolet commented 9 years ago

We are thinking Attribute for now. I have a pull request open for that.

eawagner commented 9 years ago

+1, I agree with the name Attribute and the change.

My biggest concern with this is the vast API change that this entails, as Tuple/TupleStore has become engrained into public API's in mango, flowmix and accumulo-recipes. While deprecating does protect these implementations some, if these projects plan to use the latest version of mango (as accumulo-recipes does) then they should not be exposing deprecated data objects on their API which means a very large API change on them.

As this is such a large change, should we maybe trigger a major release change? Personally, I still don't think so, but would still like to urge caution before we merge this change into master. That being said, I think if we are commited to this I would rather take care of this now than put off the pain of a large change like this til later.