search

calrissian / mango

Common utilities for rapid application development
Apache License 2.0
17 stars 7 forks source link

Remove property file requirements from CanonicalizerContext #146

Closed eawagner closed 9 years ago

eawagner commented 9 years ago

Currently, this class requires that both a validator.properties and a canonicalDef.properties be present in order to correctly use these. The worst part to this is that since, mango ships with a validator.properties file, this is the one that will always get picked up on the classpath first, meaning that we really only support two types of validation.

This class should work in a similar manner to the way the TypeEncoders class works allowing someone to programatically define their canonical context instead of through the use of these property files.

eawagner commented 9 years ago

The more I look into this, I more I think this should either be deprecate and removed, or geared more toward creating TupleStores (AttributeStores pending #142).

I am concerned that currently that this utility seems to have been flawed (with the inclusion of a default validator.properties file), yet noone has seemed to notice. Is there any interest in trying to rehab the Canonicalizer concept?

cjnolet commented 9 years ago

After some offline discussions, I'm fine deprecating this in < 2.0.0 releases and just removing post 2.0.0. This is something that can be useful but the implementation isn't really thatuseful.