Closed eawagner closed 9 years ago
Most of them use the following pattern:
for (Attribute attribute : attributes) { return comparator.compare(attribute.getValue(), value) >= 0; }
The problem with this is that it simply returns based on the first result and does not evaluate any other results. Some of them actually appear correct (the ones with unit tests), but we should correctly implement all the criteria apply methods.
Most of them use the following pattern:
The problem with this is that it simply returns based on the first result and does not evaluate any other results. Some of them actually appear correct (the ones with unit tests), but we should correctly implement all the criteria apply methods.