calrissian / mango

Common utilities for rapid application development
Apache License 2.0
17 stars 7 forks source link

AbstractAttributeStore should use the ArrayListMultiMap #194

Closed cjnolet closed 8 years ago

cjnolet commented 8 years ago

The problem is, the MultiMap interface was purposely made to not extend Serializable yet the Entity interface extends Serializable. By using the ArrayListMultimap implementation instead of the interface, this object once again becomes serializable.

eawagner commented 8 years ago

Interesting, I thought only the implementation needed to be serializable for the internal objects, but I guess it possibly makes sense that Java would have to handle null objects.

I am ok with changing the internal class reference to ArrayListMultimap since we don't expose this directly anymore through the AttributeStore API. It won't have any external effect on the classes other than when being introspected by things like Java serialization. Just a little surprised as I have never come across this case before!

eawagner commented 8 years ago

Fixed