search

calrissian / mango

Common utilities for rapid application development
Apache License 2.0
17 stars 7 forks source link

Fix use of methods that have been deprecated in new guava versions. #210

Closed eawagner closed 7 years ago

eawagner commented 7 years ago

We hit the fact that Iterators.emptyIterator() is no longer available after guava 20.

I think we should still probably stay compatible as far back as possible, but we should make sure we are still compatible with the latest version of guava.

eawagner commented 7 years ago

Do we want to change the default guava version to 20 or 21 for 2.0.0.

vincentrussell commented 7 years ago

What would be the reason to not go with the latest version?

vincentrussell commented 7 years ago

Oh... duh.. because Iterators.emptyIterator()

eawagner commented 7 years ago

I have updated master to use guava 20.0 and made sure it was compatible. I have also made sure it was compatible back to guava 15.0, with most functionality (no IPv6) working with 14.0.

Guava 21.0 is only Java8 compatible, so I opened up a new ticket #211 for adding java 8 functionality, but figure that is a little out of scope for a 2.0.0 release which is long overdue.

eawagner commented 7 years ago

This update was also very very low impact. Only use of the internal Iterators.emptyIterator were affected meaning no client code should be affected.

vincentrussell commented 7 years ago

awesome Alan. sounds great.